This repository was archived by the owner on Jan 7, 2021. It is now read-only.
Open
Conversation
Contributor
|
i am open to merge any pull request. I fixed it an named it as p3x-xml2json and it works with Nodejs 12. |
1 similar comment
Contributor
|
i am open to merge any pull request. I fixed it an named it as p3x-xml2json and it works with Nodejs 12. |
Author
|
I can confirm that the Windows installation issue in my pull request (#181) is still there and that the work around I described will allow successful windows installation.
Sent from Mail for Windows 10
From: patrikx3
Sent: Sunday, July 28, 2019 4:44 AM
To: buglabs/node-xml2json
Cc: Charles Goodwin; Author
Subject: Re: [buglabs/node-xml2json] updateREADME (#181)
i am open to merge any pull request. I fixed it an named it as p3x-xml2json and it works with Nodejs 12.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
just pull it in and i will merge and publish |
Author
|
To which repo? Buglabs or patrikx3? Thanks!
… On Jul 30, 2019, at 12:58 PM, patrikx3 ***@***.***> wrote:
just pull it in and i will merge and publish
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
as they are not responding (bugslabs) although the readme is a bit differenet and new versions, but you can add in the code and i will merge and publish it. |
Contributor
|
we are v5.2 at windows-build-tools make sure it works with 2017 or 2019... |
Author
|
The unfortunate answer is “sometimes” as to 2017/19 windows build tools, at least in my experience.
There is a note in the jump “below” about installing the 2015 if the current one doesn’t work.
The situation is truly annoying for such a great package.
From: patrikx3 <[email protected]>
Sent: Tuesday, July 30, 2019 1:05 PM
To: buglabs/node-xml2json <[email protected]>
Cc: Charles Goodwin <[email protected]>; Author <[email protected]>
Subject: Re: [buglabs/node-xml2json] updateREADME (#181)
we are v5.2 at windows-build-tools make sure it works with 2017 or 2019...
—
You are receiving this because you authored the thread.
Reply to this email directly, <#181?email_source=notifications&email_token=AHRNPBBKEUJUIA4ETYZXBF3QCBYFBA5CNFSM4HXQ2Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EUQYQ#issuecomment-516507746> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AHRNPBFWUVYQNCIAW2AHLRLQCBYFBANCNFSM4HXQ2Q3A> mute the thread. <https://github.com/notifications/beacon/AHRNPBB4BRA2YM3AAKSNP6LQCBYFBA5CNFSM4HXQ2Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EUQYQ.gif>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates README.md as to windows installation to spell out most common solution and reference additional external materails if included solution does not work.